This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[BB3] Option to ignore in session memories #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -421,6 +421,7 @@ def __init__(self, opt, shared=None): | |||
| self.agents[Module.SEARCH_KNOWLEDGE] = agent | |||
|
|
|||
| self.memories = [] | |||
| self.in_session_memories = set() | |||
There was a problem hiding this comment.
Do we need to have this as a set? Why not relying on the memory deduplication algorithm we had before?
There was a problem hiding this comment.
the set is just for quick O(1) checking in the get_available_memory function for memory utils
memory in list --> O(n)
memory in set --> O(1)
There was a problem hiding this comment.
OK, I see. I thought you had that for deduplication. That makes sense.
mojtaba-komeili
approved these changes
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Provide an option to ignore in-session memories when generating a dialogue response. An "in session memory" is any memory that is generated during the current dialogue session; a "session" is the life-cycle of the BB3 agent.
If set to
True, only memories seeded in the first observation (with the correctOpening:prefix) will be used throughout a conversation.Testing steps
Several added tests. Note: this depends on #4749 , so tests will fail until that is merged